Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landingpage update #2418

Merged
merged 6 commits into from
Jun 22, 2023
Merged

Conversation

sekyondaMeta
Copy link
Contributor

Description

Updates in this PR:

  1. Landing page update to make it easier to navigate. Similar to TorchAudio Landin page
  2. Added FAQs to side nav and removed the sphinx/resuirements.txt link from side nav
  3. Hopefully fix issue Docs are not complete #2048
  4. Simple updates to performance doc (this is a work in progress) issue Performance Optimization guide updates #2334
  5. Renamed old index.md to indexOLD.md for record keeping.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing

Built tests locally on computer see attached screenshots:

Screenshot 2023-06-19 at 11 50 48 AM

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

PR to update Landing page to make it easier to navigate.
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #2418 (036f7a3) into master (4e21262) will not change coverage.
The diff coverage is n/a.

❗ Current head 036f7a3 differs from pull request most recent head 9a6aba6. Consider uploading reports for the commit 9a6aba6 to get more accurate results

@@           Coverage Diff           @@
##           master    #2418   +/-   ##
=======================================
  Coverage   72.01%   72.01%           
=======================================
  Files          78       78           
  Lines        3648     3648           
  Branches       58       58           
=======================================
  Hits         2627     2627           
  Misses       1017     1017           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sekyondaMeta
Copy link
Contributor Author

Description

Updates in this PR:

  1. Landing page update to make it easier to navigate. Similar to TorchAudio Landin page
  2. Added FAQs to side nav and removed the sphinx/resuirements.txt link from side nav
  3. Hopefully fix issue Docs are not complete #2048
  4. Simple updates to performance doc (this is a work in progress) issue Performance Optimization guide updates #2334
  5. Renamed old index.md to indexOLD.md for record keeping.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing

Built tests locally on computer see attached screenshots:

Screenshot 2023-06-19 at 11 50 48 AM

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Also adding an update to Sphinx 5.0.0 as that is what most of the other PyTorch Docs are using plus 4.0.3 seems to be breaking when tested locally.,

@msaroufim
Copy link
Member

Is the indexOld file still needed?

@sekyondaMeta
Copy link
Contributor Author

Is the indexOld file still needed?

No, but keeping it for now in case we need to revert back to it for whatever reason. Once the PR lands and everything seems fine, I will remove it on the next PR I land.

@sekyondaMeta sekyondaMeta removed the request for review from HamidShojanazeri June 22, 2023 14:00
@msaroufim msaroufim merged commit 207477d into pytorch:master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants