-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find torchserve-plugins-sdk artifacts locally #2429
Find torchserve-plugins-sdk artifacts locally #2429
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2429 +/- ##
==========================================
+ Coverage 71.92% 72.01% +0.08%
==========================================
Files 78 78
Lines 3648 3648
Branches 58 58
==========================================
+ Hits 2624 2627 +3
+ Misses 1020 1017 -3
Partials 4 4 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall unless there is an easier workaround @lxning
@namannandan If we include building maven inside
python ts_scripts/install_dependencies.py --environment=dev
then , we can avoid having to update the workflow files
76215b4
to
2133d32
Compare
Description
Sanity in CI currently fails with the following error:
The
torchserve-plugins-sdk
are currently unavailable via JCenter or Maven Central repositories.This PR implements a workaround to find
torchserve-plugins-sdk
artifacts locally usingmavenLocal()
until they are made available on maven central repository.