-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add job queue status to describe API #2464
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2464 +/- ##
=======================================
Coverage 72.66% 72.66%
=======================================
Files 78 78
Lines 3669 3669
Branches 58 58
=======================================
Hits 2666 2666
Misses 999 999
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't break existing description attributes.
@lxning currently we don't publish any data/metrics related to job queue in the describe API endpoint. Now, I've included an additional field called Existing implementation:
With the changes in this PR:
|
public JobQueueStatus getJobQueueStatus() { | ||
return jobQueueStatus; | ||
} | ||
|
||
public void setMetrics(Metrics metrics) { | ||
this.metrics = metrics; | ||
public void setJobQueueStatus(JobQueueStatus jobQueueStatus) { | ||
this.jobQueueStatus = jobQueueStatus; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TS provide SDK to allow cx to customize the endpoint response. It will break cx's customized plugin when class Metrics and func getMetrics/etMetrics are moved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated implementation to retain the Metrics
class definition as is.
Description
Include job queue status in the describe API response:
Fixes #2101, #2412
Type of change
Feature/Issue validation/testing
Checklist: