-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that self.manifest is defined before call profiler #2488
Ensure that self.manifest is defined before call profiler #2488
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2488 +/- ##
==========================================
+ Coverage 71.90% 72.66% +0.75%
==========================================
Files 78 78
Lines 3659 3669 +10
Branches 58 58
==========================================
+ Hits 2631 2666 +35
+ Misses 1024 999 -25
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! LGTM
Tks! I will just fix the lint issue and commit again |
…serve into ensure_manifest_for_profiler
Description
Fixes #2480
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Unit test added for base handler, where I set the
self.manifest
as None, imagining a scenario where someone created a custominitialize
method and didn't definedself.manifest
, and validate if we can run_infer_with_profiler
even in this case.Before the change:
After the change
Checklist: