-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added arg to build docker with torchserve nightly #2493
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2493 +/- ##
=======================================
Coverage 72.66% 72.66%
=======================================
Files 78 78
Lines 3669 3669
Branches 58 58
=======================================
Hits 2666 2666
Misses 999 999
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to also update the time when the docker job runs. For example both the docker nightly build and torchserve build right now happen at the exact same time which means the docker nightly will be docker nightly day - 1
@msaroufim Great catch. Updated it to run couple of hours after. Sometimes, the index doesn't update immediately |
Description
Since we moved away from using Dockerfile.dev for production, Docker nightly builds are using the official version of TorchServe
This PR adds
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Checklist: