-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed typo in ModelConfig.java #2506
Conversation
Hi @arnavmehta7 Could you please check the errors in the CI runs |
Hi @agunapal, Thanks for reminder. Looks very strange. let me see the difference between my branch and master |
Strange. Doesn't seems to be through my changes @agunapal. |
This looks like the reason
|
Oh I am sorry. Fixing |
@agunapal Sorry, I've been trying to read the contributions. However there is no information on the "formatter". Somehow, my formatter formats files differently, are there any guidelines to help me out? EDIT: Oh I think, I am done. Just pushing |
Codecov Report
@@ Coverage Diff @@
## master #2506 +/- ##
=======================================
Coverage 72.66% 72.66%
=======================================
Files 78 78
Lines 3669 3669
Branches 58 58
=======================================
Hits 2666 2666
Misses 999 999
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
It's regarding markdowns, I think this is not related to my change right? |
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Corrected the documentation, it had to be "milliseconds" not "million seconds"
Checklist: