Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in ModelConfig.java #2506

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Conversation

arnavmehta7
Copy link
Contributor

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Corrected the documentation, it had to be "milliseconds" not "million seconds"

Checklist:

  • Did you have fun?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@msaroufim msaroufim self-requested a review July 29, 2023 16:06
@agunapal
Copy link
Collaborator

agunapal commented Aug 1, 2023

Hi @arnavmehta7 Could you please check the errors in the CI runs

@arnavmehta7
Copy link
Contributor Author

arnavmehta7 commented Aug 1, 2023

Hi @agunapal, Thanks for reminder. Looks very strange. let me see the difference between my branch and master

@arnavmehta7
Copy link
Contributor Author

Traceback (most recent call last):
  File "torchserve_sanity.py", line 65, in <module>
    torchserve_sanity()
  File "torchserve_sanity.py", line 46, in torchserve_sanity
    cleanup()
  File "torchserve_sanity.py", line 50, in cleanup
    ts.stop_torchserve()
  File "/home/ubuntu/actions-runner/_work/serve/serve/ts_scripts/tsutils.py", line 98, in stop_torchserve
    p = Popen(cmd, stdin=PIPE, stdout=PIPE, stderr=STDOUT)
  File "/home/ubuntu/actions-runner/_work/_tool/Python/3.8.16/x64/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/home/ubuntu/actions-runner/_work/_tool/Python/3.8.16/x64/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'torchserve'
Error: Final attempt failed. Child_process exited with error code 1

Strange. Doesn't seems to be through my changes @agunapal.

@agunapal
Copy link
Collaborator

agunapal commented Aug 1, 2023

@arnavmehta7

This looks like the reason

> Task :archive:pmdMain
Unable to exclude rules [DoNotCallSystemExit, MissingBreakInSwitch] from ruleset reference category/java/errorprone.xml; perhaps the rule name is misspelled or the rule doesn't exist anymore?
4 PMD rule violations were found. See the report at: file:///home/runner/work/serve/serve/frontend/archive/build/reports/pmd/main.html

> Task :archive:pmdTest SKIPPED
> Task :archive:verifyJava FAILED

FAILURE: Build failed with an exception.

* Where:
Script '/home/runner/work/serve/serve/frontend/tools/gradle/formatter.gradle' line: 57

* What went wrong:
Execution failed for task ':archive:verifyJava'.
> File not formatted: /home/runner/work/serve/serve/frontend/archive/src/main/java/org/pytorch/serve/archive/model/ModelConfig.java

@arnavmehta7
Copy link
Contributor Author

Oh I am sorry. Fixing

@arnavmehta7
Copy link
Contributor Author

arnavmehta7 commented Aug 1, 2023

@agunapal Sorry, I've been trying to read the contributions. However there is no information on the "formatter". Somehow, my formatter formats files differently, are there any guidelines to help me out?
Thanks!

EDIT: Oh I think, I am done. Just pushing

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #2506 (ec2b60d) into master (35ef00f) will not change coverage.
The diff coverage is n/a.

❗ Current head ec2b60d differs from pull request most recent head e50af1b. Consider uploading reports for the commit e50af1b to get more accurate results

@@           Coverage Diff           @@
##           master    #2506   +/-   ##
=======================================
  Coverage   72.66%   72.66%           
=======================================
  Files          78       78           
  Lines        3669     3669           
  Branches       58       58           
=======================================
  Hits         2666     2666           
  Misses        999      999           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arnavmehta7
Copy link
Contributor Author

@agunapal

FILE: ./ts/tests/README.md
No hyperlinks found!

It's regarding markdowns, I think this is not related to my change right?

@msaroufim msaroufim merged commit fdcc223 into pytorch:master Aug 1, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants