Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "direct buffer access" issue for Plugin SDK #2511

Merged
merged 4 commits into from
Aug 4, 2023

Conversation

marrodion
Copy link
Contributor

Description

Fixes ModelServerRequest.getInputStream() issue when the underlying buffer is a Netty direct buffer.

Fixes #2498

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Added a simple test for direct buffer write/read using SDK abstractions.
Not sure if a new test suite is justified, would be happy to move elsewhere.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #2511 (20c6882) into master (53ff6a5) will not change coverage.
The diff coverage is n/a.

❗ Current head 20c6882 differs from pull request most recent head 4534636. Consider uploading reports for the commit 4534636 to get more accurate results

@@           Coverage Diff           @@
##           master    #2511   +/-   ##
=======================================
  Coverage   72.66%   72.66%           
=======================================
  Files          78       78           
  Lines        3669     3669           
  Branches       58       58           
=======================================
  Hits         2666     2666           
  Misses        999      999           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agunapal agunapal self-requested a review August 4, 2023 19:15
@agunapal agunapal merged commit 34617bb into pytorch:master Aug 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin SDK: ModelServerRequest tries to access direct buffer
4 participants