-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update add_metric API to be backwards compatible #2525
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2525 +/- ##
==========================================
+ Coverage 72.66% 72.85% +0.19%
==========================================
Files 78 78
Lines 3669 3695 +26
Branches 58 58
==========================================
+ Hits 2666 2692 +26
Misses 999 999
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cc @duk0011 |
LGTM feel free to merge when ready @namannandan |
Documentation and example update corresponding to the API change in this PR will be included in PR: #2516 |
Description
Update the custom metrics
add_metric
API to be backwards compatible with Torchserve versions prior to v0.6.1.The
add_metric
method retains the same API signature but the change in semantics is that v0.6.1 introduced types for metrics metricTypes and the default inferred type if not specified when usingadd_metric
API isCOUNTER
.add_metric
API in versions prior to v0.6.1add_metric
API in versions v0.6.1 onwardsadd_metric
API introduced in this PR for backwards compatibility with versions prior to v0.6.1Type of change
Feature/Issue validation/testing