Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix kserve storage optional package #2537

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Conversation

jagadeeshi2i
Copy link
Collaborator

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #2537 (7eb19c1) into master (b37296d) will not change coverage.
The diff coverage is n/a.

❗ Current head 7eb19c1 differs from pull request most recent head dfa9646. Consider uploading reports for the commit dfa9646 to get more accurate results

@@           Coverage Diff           @@
##           master    #2537   +/-   ##
=======================================
  Coverage   72.85%   72.85%           
=======================================
  Files          78       78           
  Lines        3695     3695           
  Branches       58       58           
=======================================
  Hits         2692     2692           
  Misses        999      999           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@agunapal agunapal merged commit cd7c47e into pytorch:master Aug 24, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants