Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update large_model_inference.md #2542

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

sekyondaMeta
Copy link
Contributor

Description

Adding DeepSpeed MII and Hugging face accelerate information to LMI doc.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Built pages locally.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #2542 (0c43413) into master (a599fa0) will not change coverage.
The diff coverage is n/a.

❗ Current head 0c43413 differs from pull request most recent head baf1cbd. Consider uploading reports for the commit baf1cbd to get more accurate results

@@           Coverage Diff           @@
##           master    #2542   +/-   ##
=======================================
  Coverage   72.64%   72.64%           
=======================================
  Files          79       79           
  Lines        3733     3733           
  Branches       58       58           
=======================================
  Hits         2712     2712           
  Misses       1017     1017           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -1,6 +1,13 @@
# Serving large models with Torchserve

This document explain how Torchserve supports large model serving, here large model refers to the models that are not able to fit into one gpu so they need be split in multiple partitions over multiple gpus.
This page is split into the following sections:
- [How it works](#how-it-works)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember there was some issue with relative links when we go to pytorch.org so might wanna double check this works, if it does feel free to dismiss this comment

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending one query about low_cpu_mem_usage=True, rest looks fine

docs/large_model_inference.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@HamidShojanazeri HamidShojanazeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion

docs/large_model_inference.md Outdated Show resolved Hide resolved
@HamidShojanazeri HamidShojanazeri added this pull request to the merge queue Aug 30, 2023
Merged via the queue into pytorch:master with commit 30ff033 Aug 30, 2023
10 of 12 checks passed
@sekyondaMeta sekyondaMeta deleted the lmiDeepspeedmii branch September 13, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants