-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor conda build script to publish all binaries from ubuntu machine #2561
Refactor conda build script to publish all binaries from ubuntu machine #2561
Conversation
…apal/serve into issues/refactor_conda_build
Could you also please sanity check that a converted binary also works? Most convincing would be to run our test suite |
Codecov Report
@@ Coverage Diff @@
## master #2561 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 79 79
Lines 3742 3742
Branches 58 58
=======================================
Hits 2721 2721
Misses 1017 1017
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@msaroufim Added logs of the manual test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few minor nits left otherwise lgtm
Description
This PR refactor's conda build scripts to
- Build conda binaries for linux
- Use
conda convert
to create binaries for all other platforms- Currently, the platforms are
win-64
andosx-64
- To publish to a new platform, ex:
osx-arm64
, we just need to add this string to the list- Changes torchserve binary publishing workflows to use only ubuntu
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Below is a screenshot of files being uploaded from a workflow
You can find all the files here
https://anaconda.org/agunapal/repo
Workflow run is here
https://github.com/agunapal/serve/actions/runs/6032298050
Installing Binaries on osx-64 with Python 3.10
Test
I commented install_from_src in our regression scripts and ran the following
Checklist: