-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nightly build for torchserve-kfs image #2574
Conversation
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Codecov Report
@@ Coverage Diff @@
## master #2574 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 79 79
Lines 3742 3742
Branches 58 58
=======================================
Hits 2721 2721
Misses 1017 1017
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please share a link to/screenshot of publishing these binaries to your dockerhub?
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Workflow run: https://github.com/jagadeeshi2i/serve/actions/runs/6108738716/job/16578339051 |
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments inline and attach test logs
Added logs for image building with run commands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 5e30a7d.
Description
Workflow run: https://github.com/jagadeeshi2i/serve/actions/runs/6108738716/job/16578339051
Image Build logs: torchserve-kfs-nightly.log
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Checklist: