Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nightly build for torchserve-kfs image #2574

Merged
merged 4 commits into from
Sep 10, 2023

Conversation

jagadeeshi2i
Copy link
Collaborator

@jagadeeshi2i jagadeeshi2i commented Sep 6, 2023

Description

Workflow run: https://github.com/jagadeeshi2i/serve/actions/runs/6108738716/job/16578339051
Image Build logs: torchserve-kfs-nightly.log

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #2574 (27d5179) into master (7253668) will not change coverage.
The diff coverage is n/a.

❗ Current head 27d5179 differs from pull request most recent head 01ddee2. Consider uploading reports for the commit 01ddee2 to get more accurate results

@@           Coverage Diff           @@
##           master    #2574   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files          79       79           
  Lines        3742     3742           
  Branches       58       58           
=======================================
  Hits         2721     2721           
  Misses       1017     1017           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please share a link to/screenshot of publishing these binaries to your dockerhub?

kubernetes/kserve/docker_nightly.py Outdated Show resolved Hide resolved
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
@jagadeeshi2i
Copy link
Collaborator Author

Can you please share a link to/screenshot of publishing these binaries to your dockerhub?

Workflow run: https://github.com/jagadeeshi2i/serve/actions/runs/6108738716/job/16578339051

kubernetes/kserve/docker_nightly.py Outdated Show resolved Hide resolved
Signed-off-by: jagadeesh <jagadeeshj@ideas2it.com>
Copy link
Contributor

@chauhang chauhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments inline and attach test logs

@jagadeeshi2i
Copy link
Collaborator Author

jagadeeshi2i commented Sep 8, 2023

Please see comments inline and attach test logs

Added logs for image building with run commands

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into pytorch:master with commit 5e30a7d Sep 10, 2023
12 checks passed
msaroufim added a commit that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants