Implement Test for ModelRequestEncoder

[abergmeier]

Description

Implemented ModelRequestEncoderTest. Currently tests Inference protocol only.

Type of change

Increased Unittest coverage for inference.

Feature/Issue validation/testing

• org.pytorch.serve.util.codec.ModelRequestEncoderTest.testEmpty
• org.pytorch.serve.util.codec.ModelRequestEncoderTest.testSimple

Checklist:

• Did you have fun?
• Have you added tests that prove your fix is effective or that this feature works?
• Has code been commented, particularly in hard-to-understand areas?
• Have you made corresponding changes to the documentation?

[mreso]

Hi @abergmeier thanks for contributing this test! Could you please address the CI failure?

[abergmeier]

Hi @abergmeier thanks for contributing this test! Could you please address the CI failure?

Well the CI seems to have quite a bit of noise to signal ratio.
From what I could make out it seems like there is some formatting problem.
The CI and docs seem to be not very specific what formatting is expected/how that formatting can be reached.
Also, other CI failures seem to stem from flakiness.

So I am not really confident, that I will be able to solve CI failures without some guidance.

[agunapal]

@abergmeier Did you try building frontend https://github.com/pytorch/serve/tree/master/frontend

There is a formatter here https://github.com/pytorch/serve/blob/master/frontend/build.gradle#L45

[abergmeier]

@abergmeier Did you try building frontend https://github.com/pytorch/serve/tree/master/frontend

frontend on master does not even build/test successful on my Ubuntu 22.04. I assume there is implicit configuration/dependencies which are not present on my machine.

There is a formatter here https://github.com/pytorch/serve/blob/master/frontend/build.gradle#L45

Mabye I was not clear enough. I am no Java developer.
So for me to be able to produce a patch that is formatted in a way that you accept I assume I need a way of running a formatter on these files. I have no idea how I run the appropriate formatter.

[lxning]

@abergmeier you can format java code via command:

cd frontend
./gradlew format

[codecov]

Codecov Report

Merging #2580 (cdbf9e3) into master (f10a071) will not change coverage.
The diff coverage is n/a.

❗ Current head cdbf9e3 differs from pull request most recent head 06aab73. Consider uploading reports for the commit 06aab73 to get more accurate results

@@           Coverage Diff           @@
##           master    #2580   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files          85       85           
  Lines        3956     3956           
  Branches       58       58           
=======================================
  Hits         2864     2864           
  Misses       1088     1088           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[abergmeier]

Can this PR land?

[mreso]

LGTM

[mreso]

Thanks @abergmeier a lot for contributing this test