Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/update docker newman #2603

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Issues/update docker newman #2603

merged 2 commits into from
Sep 19, 2023

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Sep 19, 2023

Description

Fix required to fix docker nightly regression Run

  • Pin newman version to 5.3.2
  • Creates a GH issue in case of failure. This test has been stable for the most part

Passing Run:
https://github.com/pytorch/serve/actions/runs/6239067938

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Shared the passing run

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #2603 (86d23c3) into master (2bf505b) will not change coverage.
The diff coverage is n/a.

❗ Current head 86d23c3 differs from pull request most recent head 18b1cfe. Consider uploading reports for the commit 18b1cfe to get more accurate results

@@           Coverage Diff           @@
##           master    #2603   +/-   ##
=======================================
  Coverage   70.87%   70.87%           
=======================================
  Files          83       83           
  Lines        3839     3839           
  Branches       58       58           
=======================================
  Hits         2721     2721           
  Misses       1114     1114           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agunapal agunapal added this pull request to the merge queue Sep 19, 2023
Merged via the queue into master with commit 80b1679 Sep 19, 2023
12 checks passed
@agunapal agunapal deleted the issues/update_docker_newman branch September 19, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants