Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for PyTorch 2.1.0 and Python 3.11 #2621

Merged
merged 6 commits into from
Sep 29, 2023
Merged

Changes for PyTorch 2.1.0 and Python 3.11 #2621

merged 6 commits into from
Sep 29, 2023

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Sep 27, 2023 •
edited
Loading

Description

Changes need to support PyTorch 2.1.0

  • Includes support for CUDA 12.1 (Default version)
  • Includes conda binary builds for python 3.11
  • Docker builds with CUDA 12.1
  • Updates to documentation
    Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Passing CI/ Regression Runs

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Sep 27, 2023 •
edited
Loading

Codecov Report

Merging #2621 (ec9cc03) into master (d8a1146) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head ec9cc03 differs from pull request most recent head f54c3b7. Consider uploading reports for the commit f54c3b7 to get more accurate results

@@            Coverage Diff             @@
##           master    #2621      +/-   ##
==========================================
- Coverage   71.34%   71.24%   -0.11%     
==========================================
  Files          85       85              
  Lines        3905     3905              
  Branches       58       58              
==========================================
- Hits         2786     2782       -4     
- Misses       1115     1119       +4     
  Partials        4        4

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agunapal agunapal changed the title (WIP) Changes for PyTorch 2.1.0 and Python 3.11 Changes for PyTorch 2.1.0 and Python 3.11 Sep 28, 2023
lxning
lxning reviewed Sep 28, 2023
View reviewed changes
docker/README.md
@@ -37,11 +37,11 @@ Use `build_image.sh` script to build the docker images. The script builds the `p
|-bi, --baseimage specify base docker image. Example: nvidia/cuda:11.8.0-cudnn8-runtime-ubuntu20.04|
|-bt, --buildtype|Which type of docker image to build. Can be one of : production, dev, ci, codebuild|
|-t, --tag|Tag name for image. If not specified, script uses torchserve default tag names.|
|-cv, --cudaversion| Specify to cuda version to use. Supported values `cu92`, `cu101`, `cu102`, `cu111`, `cu113`, `cu116`, `cu117`, `cu118`. Default `cu117`|
|-cv, --cudaversion| Specify to cuda version to use. Supported values `cu92`, `cu101`, `cu102`, `cu111`, `cu113`, `cu116`, `cu117`, `cu118`. `cu121`, Default `cu121`|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please confirm if cu121 is PT2.1 default cuda?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed

msaroufim
msaroufim reviewed Sep 28, 2023
View reviewed changes
binaries/conda/build_packages.py
@@ -130,7 +130,7 @@ def conda_build(

os.environ["PYTHON"] = "python"

python_versions = ["3.8", "3.9", "3.10"]
python_versions = ["3.8", "3.9", "3.10", "3.11"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure you wanna keep 3.8 around?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should support it as long as PyTorch does. But I think we should update our default version in workflows to 3.9

msaroufim
msaroufim reviewed Sep 28, 2023
View reviewed changes
docs/getting_started.md
@@ -14,10 +14,10 @@
python ./ts_scripts/install_dependencies.py
```

- For GPU with Cuda 10.2. Options are `cu92`, `cu101`, `cu102`, `cu111`, `cu113`, `cu116`, `cu117`, `cu118`
- For GPU with Cuda 12.1. Options are `cu92`, `cu101`, `cu102`, `cu111`, `cu113`, `cu116`, `cu117`, `cu118`, `cu121`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this list is long no? :P

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we should truncate this to the latest version. Good point. Anyone looking for 0.6.0 can look at the readme page corresponding to 0.6.0 tag

@lxning lxning added this pull request to the merge queue Sep 29, 2023
Merged via the queue into master with commit 7123319 Sep 29, 2023
12 checks passed
@agunapal agunapal deleted the feature/update_pt2.1 branch October 3, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxning lxning lxning approved these changes

@msaroufim msaroufim msaroufim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agunapal @msaroufim @lxning