Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default address from 0.0.0.0 to 127.0.0.1 in documentation and examples #2624

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

namannandan
Copy link
Collaborator

Fixes #2610

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #2624 (5e3c1b9) into master (8bd76ee) will increase coverage by 1.89%.
Report is 118 commits behind head on master.
The diff coverage is 73.47%.

❗ Current head 5e3c1b9 differs from pull request most recent head c5d0cef. Consider uploading reports for the commit c5d0cef to get more accurate results

@@            Coverage Diff             @@
##           master    #2624      +/-   ##
==========================================
+ Coverage   69.44%   71.34%   +1.89%     
==========================================
  Files          77       85       +8     
  Lines        3450     3905     +455     
  Branches       57       58       +1     
==========================================
+ Hits         2396     2786     +390     
- Misses       1051     1115      +64     
- Partials        3        4       +1     
Files Coverage Δ
...l-archiver/model_archiver/model_packaging_utils.py 92.30% <100.00%> (+32.17%) ⬆️
setup.py 0.00% <ø> (ø)
ts/arg_parser.py 25.80% <ø> (ø)
ts/context.py 67.53% <ø> (ø)
ts/metrics/caching_metric.py 89.47% <100.00%> (ø)
ts/metrics/metric_abstract.py 92.85% <100.00%> (ø)
ts/metrics/metric_cache_abstract.py 93.18% <100.00%> (+0.41%) ⬆️
ts/metrics/metric_cache_yaml_impl.py 93.24% <100.00%> (ø)
ts/model_loader.py 88.31% <ø> (ø)
...sts/metrics_yaml_testing/metric_cache_unit_test.py 99.68% <100.00%> (+0.02%) ⬆️
... and 20 more

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@namannandan namannandan changed the title Update default address from 0.0.0.0 to 127.0.0.1 Update default address from 0.0.0.0 to 127.0.0.1 in documentation and examples Oct 2, 2023
@namannandan namannandan marked this pull request as ready for review October 2, 2023 17:09
@msaroufim msaroufim merged commit 8dfa6c8 into master Oct 2, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default IP address setting
2 participants