Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Netty HTTP header validation #2630

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Enable Netty HTTP header validation #2630

merged 2 commits into from
Sep 30, 2023

Conversation

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #2630 (728afb1) into master (d8a1146) will decrease coverage by 0.11%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

❗ Current head 728afb1 differs from pull request most recent head 6f83d44. Consider uploading reports for the commit 6f83d44 to get more accurate results

@@            Coverage Diff             @@
##           master    #2630      +/-   ##
==========================================
- Coverage   71.34%   71.24%   -0.11%     
==========================================
  Files          85       85              
  Lines        3905     3905              
  Branches       58       58              
==========================================
- Hits         2786     2782       -4     
- Misses       1115     1119       +4     
  Partials        4        4              

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msaroufim msaroufim added this pull request to the merge queue Sep 29, 2023
Merged via the queue into master with commit eaad8a4 Sep 30, 2023
11 of 12 checks passed
@lxning
Copy link
Collaborator

lxning commented Sep 30, 2023

I'm not sure if there is a history reason of setting false at beginning. I suggest making it configurable (default: true) to avoid breaking some cx prod.

@msaroufim
Copy link
Member Author

Would be nice to have sanity checks in CI for what sagemaker might do but regardless I opened this issue to follow up on later #2639 - would be great if someone wants to pick this up

@msaroufim msaroufim deleted the msaroufim/nettyval branch September 30, 2023 19:20
@msaroufim msaroufim restored the msaroufim/nettyval branch October 1, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants