Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version to 18 #2663

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Update node version to 18 #2663

merged 1 commit into from
Oct 4, 2023

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Oct 3, 2023

Description

Upgrades node version from 14 to 18 as 14 has been deprecated.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2663 (cc3f0f9) into master (a6fd770) will not change coverage.
The diff coverage is n/a.

❗ Current head cc3f0f9 differs from pull request most recent head 82a17c3. Consider uploading reports for the commit 82a17c3 to get more accurate results

@@           Coverage Diff           @@
##           master    #2663   +/-   ##
=======================================
  Coverage   71.34%   71.34%           
=======================================
  Files          85       85           
  Lines        3905     3905           
  Branches       58       58           
=======================================
  Hits         2786     2786           
  Misses       1115     1115           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agunapal agunapal changed the title (WIP) Update node version to 18 Update node version to 18 Oct 3, 2023
@agunapal agunapal requested a review from lxning October 3, 2023 22:10
@msaroufim msaroufim self-requested a review October 4, 2023 00:52
@msaroufim msaroufim added this pull request to the merge queue Oct 4, 2023
Merged via the queue into master with commit 7b36a5d Oct 4, 2023
12 checks passed
@agunapal agunapal deleted the issues/upgrade_node_version branch October 4, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants