Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating security documentation: allowed_urls #2690

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Oct 9, 2023

Description

Updates security guidelines to configure allowed_urls in production

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

N?A

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2690 (7a432bb) into master (4d6dbe6) will not change coverage.
The diff coverage is n/a.

❗ Current head 7a432bb differs from pull request most recent head 49ffe39. Consider uploading reports for the commit 49ffe39 to get more accurate results

@@           Coverage Diff           @@
##           master    #2690   +/-   ##
=======================================
  Coverage   72.39%   72.39%           
=======================================
  Files          85       85           
  Lines        3956     3956           
  Branches       58       58           
=======================================
  Hits         2864     2864           
  Misses       1088     1088           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lxning
Copy link
Collaborator

lxning commented Oct 10, 2023

please include this info: https://github.com/pytorch/serve/pull/2685/files#diff-17ed18489a956f326ec0fe4040850c5bc9261d4631fb42da4c52891d74a59180

@agunapal agunapal added this pull request to the merge queue Oct 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 10, 2023
@agunapal agunapal added this pull request to the merge queue Oct 10, 2023
Merged via the queue into master with commit 6a42b5c Oct 10, 2023
12 of 13 checks passed
@agunapal agunapal deleted the docs/update_security_guidelines_1 branch October 10, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants