Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
metric_abstract.py
, theunit
attribute is not assigned if it is not one of the units defined in unit.pyserve/ts/metrics/metric_abstract.py
Lines 43 to 44 in 0510772
This can lead to the following error when attempting to emit the metric:
Fixes #2637
Type of change
Feature/Issue validation/testing
Unit test included in this PR that runs as part of CI
Manual test
Testing the following call to emit metric in handler code across different versions
v0.6.0
v0.8.2
With fix in this PR