Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipping flaky newman test #2696

Merged
merged 3 commits into from
Oct 11, 2023
Merged

Conversation

agunapal
Copy link
Collaborator

Description

This newman test has become flaky. Skipping till we rootcause it

  #  failure         detail                            
                                                       
 1.  AssertionError  Successful  request               
     iteration: 3    expected 500 to be one of [ 200 ] 
                     at assertion:0 in test-script     
                     inside "Workflow - Inference"     
                                                       
 2.  AssertionError  Test expected JSON response       
     iteration: 3    expected false to be true         
                     at assertion:1 in test-script     
                     inside "Workflow - Inference"     

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #2696 (6aacc06) into master (447f3ef) will not change coverage.
The diff coverage is n/a.

❗ Current head 6aacc06 differs from pull request most recent head 8112a8a. Consider uploading reports for the commit 8112a8a to get more accurate results

@@           Coverage Diff           @@
##           master    #2696   +/-   ##
=======================================
  Coverage   72.44%   72.44%           
=======================================
  Files          85       85           
  Lines        3963     3963           
  Branches       58       58           
=======================================
  Hits         2871     2871           
  Misses       1088     1088           
  Partials        4        4           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@agunapal agunapal changed the title (WIP)skipping flaky newman test skipping flaky newman test Oct 11, 2023
Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also open an issue to track fixing this

@agunapal
Copy link
Collaborator Author

Opened an issue #2702 to track this

@agunapal agunapal added this pull request to the merge queue Oct 11, 2023
Merged via the queue into master with commit 76aa453 Oct 11, 2023
13 checks passed
@agunapal agunapal deleted the issues/regression_skip_newman_wf_test branch October 11, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants