Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vLLM example with mistral7B model #2781

Merged
merged 12 commits into from
Dec 9, 2023
Merged

vLLM example with mistral7B model #2781

merged 12 commits into from
Dec 9, 2023

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Nov 9, 2023

Description

This example shows how to use vLLM to run inference on mistral7b model

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

curl -v "http://localhost:8080/predictions/mistral7b" -T sample_text.txt

results in the following output

Mayonnaise is made of eggs, oil, vinegar, salt and pepper. Using an electric blender, combine all the ingredients and beat at high speed for 4 to 5 minutes.

Try it with some mustard and paprika mixed in, and a bit of sweetener if you like. But use real mayonnaise or it isn’t the same. Marlou

What in the world is mayonnaise?

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal requested a review from lxning November 13, 2023 20:44
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some inline comments. Besides that a solid example.

examples/large_models/vllm/mistral/model-config.yaml Outdated Show resolved Hide resolved
examples/large_models/vllm/mistral/custom_handler.py Outdated Show resolved Hide resolved
examples/large_models/vllm/mistral/Readme.md Show resolved Hide resolved
examples/large_models/vllm/mistral/Readme.md Outdated Show resolved Hide resolved
examples/large_models/vllm/mistral/custom_handler.py Outdated Show resolved Hide resolved
examples/large_models/vllm/mistral/custom_handler.py Outdated Show resolved Hide resolved
examples/large_models/vllm/mistral/custom_handler.py Outdated Show resolved Hide resolved
examples/large_models/vllm/mistral/custom_handler.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all comments! LGTM

@mreso mreso enabled auto-merge December 9, 2023 04:51
@mreso mreso added this pull request to the merge queue Dec 9, 2023
Merged via the queue into master with commit 177ffcd Dec 9, 2023
13 checks passed
@chauhang chauhang added this to the v0.10.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants