Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that "Not Accepted" is a valid classification #2786

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Clarify that "Not Accepted" is a valid classification #2786

merged 1 commit into from
Nov 13, 2023

Conversation

nathanweeks
Copy link
Contributor

Description

In the examples/Huggingface_Transformers Sequence Classification example, clarify that "Not Accepted" is a valid classification response, rather than a TorchServe error.

Fixes #1848

Type of change

  • Bug fix (non-breaking change which fixes an issue)

agunapal
agunapal approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal added this pull request to the merge queue Nov 13, 2023
Merged via the queue into pytorch:master with commit 497e16f Nov 13, 2023
12 of 13 checks passed
@nathanweeks nathanweeks deleted the patch-1 branch November 13, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agunapal agunapal agunapal approved these changes

@HamidShojanazeri HamidShojanazeri Awaiting requested review from HamidShojanazeri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing Sequence Classification Example for HuggingFace
2 participants
@nathanweeks @agunapal