Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k8s image BASE_IMAGE #2808

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

rsbowman-striveworks
Copy link
Contributor

Description

docker/build_image.sh creates a CPU image with tag 'latest-cpu'. Use that tag when building the k8s kserve image.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Build several containers using this fix.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

docker/build_image.sh creates a CPU image with tag 'latest-cpu'.  Use
that tag when building the k8s kserve image.
@agunapal
Copy link
Collaborator

So, we do tag the latest-cpu image as latest here

@rsbowman-striveworks
Copy link
Contributor Author

So, we do tag the latest-cpu image as latest here

We're building some custom images and don't use the build_upload_release.py workflow. Would be nice if we could just call docker/build_image.sh and then kubernetes/kserve/build_image.sh. Not a big deal either way, though.

@agunapal
Copy link
Collaborator

Thanks @rsbowman-striveworks . Sounds good. Approving this

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal added this pull request to the merge queue Nov 28, 2023
Merged via the queue into pytorch:master with commit 709e743 Nov 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants