-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include SAM vit_h in torch.compile nightly benchmark workflow and change model artifact name for SAM vit_b #2863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- what is the process batch size for the models?
- according to the setting, this PR is for latency test case. Please reflect it in the name of config.yaml
|
batch_size: | ||
- 1 | ||
input: "./examples/large_models/segment_anything_fast/kitten.jpg" | ||
requests: 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are 1000 requests sufficient?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the TPS for vit_h is around 4 and the TPS for vit_b is around 5.2, I think 1000 requests should be sufficient. I have tried running the benchmark with a higher number of requests but the results were the same
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
The objective of this PR is to include the SAM Fast model with weights corresponding to vit_h and a process batch size of 8. Also, this PR fixes the name of the SAM Fast vit_b model artifact.
The following TAR file contains the sam_fast_vit_b and sam_fast_vit_h MAR files: sam_fast_models.tar.gz
Testing:
sam_fast_vit_b_01ec64.mar
andsam_fast_vit_h_4b8939.mar
to https://torchserve.pytorch.org/mar_files/sam_fast_vit_b_01ec64.mar and https://torchserve.pytorch.org/mar_files/sam_fast_vit_h_4b8939.mar respectively for the benchmark workflow test.Steps after merging PR:
sam_fast_vit_b_01ec64.mar
andsam_fast_vit_h_4b8939.mar
to https://torchserve.pytorch.org/mar_files/sam_fast_vit_b_01ec64.mar and https://torchserve.pytorch.org/mar_files/sam_fast_vit_h_4b8939.mar.UPDATE:
sam_fast_models.tar.gz