Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling flaky test #2864

Merged
merged 1 commit into from
Dec 21, 2023
Merged

disabling flaky test #2864

merged 1 commit into from
Dec 21, 2023

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Dec 21, 2023

Description

Disabling the test test_register_model_with_batch_size since this seems flaky on regression runs on GPU

Passing run

 pytest -v test_model_config.py 
================================================================================== test session starts ===================================================================================
platform linux -- Python 3.10.0, pytest-7.3.1, pluggy-1.0.0 -- /home/ubuntu/anaconda3/envs/ts_aot_compile/bin/python
cachedir: .pytest_cache
rootdir: /home/ubuntu/serve
plugins: cov-4.1.0, mock-3.12.0
collected 2 items                                                                                                                                                                        

test_model_config.py::test_register_model_with_batch_size PASSED                                                                                                                   [ 50%]
test_model_config.py::test_register_model_without_batch_size PASSED      

Failing run

pytest -v test_model_config.py 
================================================================================== test session starts ===================================================================================
platform linux -- Python 3.10.0, pytest-7.3.1, pluggy-1.0.0 -- /home/ubuntu/anaconda3/envs/ts_aot_compile/bin/python
cachedir: .pytest_cache
rootdir: /home/ubuntu/serve
plugins: cov-4.1.0, mock-3.12.0
collected 2 items                                                                                                                                                                        

test_model_config.py::test_register_model_with_batch_size FAILED                                                                                                                   [ 50%]
test_model_config.py::test_register_model_without_batch_size PASSED    

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal requested a review from lxning December 21, 2023 00:47
@agunapal agunapal added this pull request to the merge queue Dec 21, 2023
Merged via the queue into master with commit ed47cc6 Dec 21, 2023
13 checks passed
@agunapal agunapal deleted the issues/disable_pytest_model_config branch December 21, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants