-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Inf2 package dependency version conflicts #2887
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the motivation to remove the dependencies altogether rather than handle the version dependency conflict? Also, the conflict seems to exist for protobuf
and grpcio-tools
. Why are we removing numpy
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove numpy
and protobuf
because neuronx-cc
will setup the required supported version of numpy
and torch-neuronx
will do the same for protobuf
. This way, we don't have to hardcode individual package versions. Also, grpcio-tools
is not a dependency for neuronx-cc
, torch-neuronx
or transformers-neuronx
so I've removed that as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Recent Inf2 benchmark runs have been failing due to conflicting package versions as follows:
Type of change
Feature/Issue validation/testing
Inf2 benchmark