Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build torchserve nightly GPU image with torchserve nightly #2891

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Jan 8, 2024

Description

There is a bug in the nightly docker build script where torchserve nightly is being used only for CPU and not GPU images.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

  • Before
    Screenshot 2024-01-08 at 3 03 56 PM

  • After
    Screenshot 2024-01-08 at 3 23 02 PM

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal added this pull request to the merge queue Jan 9, 2024
Merged via the queue into master with commit cad84ff Jan 9, 2024
13 checks passed
@agunapal agunapal deleted the issues/docker_gpu_ts_nightly branch January 9, 2024 01:10
@chauhang chauhang added this to the v0.10.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants