Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling venv test from docker regression #2943

Closed
wants to merge 2 commits into from

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Feb 11, 2024

Description

Failing regression run: https://github.com/pytorch/serve/actions/runs/7852861004

Created this issue to track disabling of test_install_dependencies_to_venv_with_requirements from docker regression
#2942

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal changed the title disabling venv test from docker regression (WIP)disabling venv test from docker regression Feb 11, 2024
@msaroufim
Copy link
Member

It's actually concerning this doesnt work though, I'd actually just fix this instead since I don't think you can make a release until this is fixed

@agunapal agunapal changed the title (WIP)disabling venv test from docker regression disabling venv test from docker regression Feb 12, 2024
@namannandan
Copy link
Collaborator

Identified root cause of failure here: #2942 (comment)

@namannandan namannandan force-pushed the issues/disable_venv_test_docker branch from b43b911 to 4886fea Compare February 16, 2024 20:33
@agunapal
Copy link
Collaborator Author

closing as this PR addresses the problem #2946

@agunapal agunapal closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants