Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skipping macos regression for python 3.8 #2960

Merged
merged 8 commits into from
Feb 22, 2024
Merged

skipping macos regression for python 3.8 #2960

merged 8 commits into from
Feb 22, 2024

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Feb 22, 2024 •
edited
Loading

Description

Skip running regressions on mac-OS for python 3.8 as onnxruntime has stopped supporting this.

TODO: Need a better system to handle these dependencies
Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal marked this pull request as ready for review February 22, 2024 19:36
@agunapal agunapal requested a review from lxning February 22, 2024 19:36
@agunapal agunapal requested a review from mreso February 22, 2024 22:20
@agunapal agunapal added this pull request to the merge queue Feb 22, 2024
Merged via the queue into master with commit e32e95a Feb 22, 2024
15 of 17 checks passed
@agunapal agunapal deleted the issues/regression_binaries_macOs branch February 28, 2024 00:03
muthuraj-i2i pushed a commit to muthuraj-i2i/serve that referenced this pull request Mar 1, 2024
@agunapal @andyi2it
skipping macos regression for python 3.8 (pytorch#2960)
456813f 
* skipping macos regression for python 3.8

* skipping macos regression for python 3.8

* updating actions checkout version

* updating actions checkout version

* use exclude

* skipping macos regression for python 3.8

* skipping macos regression for python 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxning lxning lxning approved these changes

@msaroufim msaroufim Awaiting requested review from msaroufim

@mreso mreso Awaiting requested review from mreso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agunapal @lxning