Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Dockerfile #2982

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix Dockerfile #2982

merged 1 commit into from
Feb 29, 2024

Conversation

fyang93
Copy link
Contributor

@fyang93 fyang93 commented Feb 29, 2024

Description

On L74, if [ "USE_CUDA_VERSION" ]; is fixed to if [ "$USE_CUDA_VERSION" ];.
No dependencies are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Run ./build_image.sh -cv cu118 -py 3.9 -t torchserve:dev-base &> build.log.
Without the fix, you may find [compile-image 8/9] RUN ... if [ "USE_CUDA_VERSION" ]; then ... in build.log, after the fix, the log would be [compile-image 8/9] RUN ... if [ "cu118" ]; then ... which is the original author's intention in my understanding.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal
Copy link
Collaborator

Thanks for reporting the issue.

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal added this pull request to the merge queue Feb 29, 2024
Merged via the queue into pytorch:master with commit ca3984a Feb 29, 2024
15 checks passed
muthuraj-i2i pushed a commit to muthuraj-i2i/serve that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants