Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On L74,
if [ "USE_CUDA_VERSION" ];
is fixed toif [ "$USE_CUDA_VERSION" ];
.No dependencies are required for this change.
Type of change
Feature/Issue validation/testing
Run
./build_image.sh -cv cu118 -py 3.9 -t torchserve:dev-base &> build.log
.Without the fix, you may find
[compile-image 8/9] RUN ... if [ "USE_CUDA_VERSION" ]; then ...
in build.log, after the fix, the log would be[compile-image 8/9] RUN ... if [ "cu118" ]; then ...
which is the original author's intention in my understanding.Checklist: