Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated TorchVision and PyTorch APIs #3074

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Update deprecated TorchVision and PyTorch APIs #3074

merged 4 commits into from
Apr 4, 2024

Conversation

kit1980
Copy link
Member

@kit1980 kit1980 commented Apr 4, 2024 •
edited
Loading

Description

  1. For TorchVision models, pretrained parameters have been deprecated in favor of "Multi-weight support API" - see https://pytorch.org/vision/0.15/models.html
  2. torch.qr updated to torch.linalg.qr

Found with https://github.com/pytorch-labs/torchfix/

Also applied pre-commit to pass linter.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

This should be a no-op.

@kit1980 kit1980 marked this pull request as ready for review April 4, 2024 00:35
@msaroufim msaroufim self-requested a review April 4, 2024 19:42
msaroufim
msaroufim approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@msaroufim msaroufim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@msaroufim msaroufim added this pull request to the merge queue Apr 4, 2024
Merged via the queue into master with commit 4f90708 Apr 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msaroufim msaroufim msaroufim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kit1980 @msaroufim @agunapal