-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make a copy of the torchtext utils to remove dependency #3076
Conversation
We should also consider removing https://github.com/pytorch/serve/tree/master/examples/text_classification_with_scriptable_tokenizer as it depends on torchtext as well. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please address comment before merging
…com/pytorch/serve into feature/remove_torchtext_dependency
Description
This PR removes the dependency of TorchServe's
TextClassifier
Handler onTorchText
by copying the functions that are being usedFixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
CI & Regression Pass which use
TextClassifier
Checklist: