Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes - gRPC management api errors when version not specified #3095

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

harshita-meena
Copy link
Contributor

@harshita-meena harshita-meena commented Apr 18, 2024

Description

Running gRPCurl command without a version (even though it is optional) gives
Screen Shot 2024-04-18 at 8 40 42 AM
, this fix ensures that not specifying version with gRPC works too just like REST API.
grpcurl -plaintext -d '{"model_name": "toy-ranker", "customized": true}' -proto serve/frontend/server/src/main/resources/proto/management.proto localhost:7071 org.pytorch.serve.grpc.management.ManagementAPIsService/DescribeModel
Screen Shot 2024-04-18 at 8 43 08 AM

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@harshita-meena harshita-meena changed the title gRPC management api does not accept empty version Fixes - gRPC management api errors when version not specified Apr 18, 2024
@agunapal agunapal added the java Pull requests that update Java code label Apr 18, 2024
@agunapal agunapal requested a review from lxning April 18, 2024 16:08
@lxning lxning enabled auto-merge April 18, 2024 16:41
@lxning lxning added this pull request to the merge queue Apr 18, 2024
Merged via the queue into pytorch:master with commit 1ec8932 Apr 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants