Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI and Regression workflows for MAC Arm64 #3128

Merged
merged 12 commits into from
May 9, 2024
Merged

Fix CI and Regression workflows for MAC Arm64 #3128

merged 12 commits into from
May 9, 2024

Conversation

namannandan
Copy link
Collaborator

@namannandan namannandan commented May 1, 2024 •
edited
Loading

Description

The Mac CI and regression failures are being caused by the following reasons:

  1. The macos-lastest github runner tag now points to arm64 based Mac.
  2. PyTorch 2.3 has dropped support for x86 Mac.
  3. The M1 mac github runners do not expose the GPU(MPS hardware)
    Add GPU Passthrough (Metal) for GitHub-hosted macOS runners actions/runner-images#7085
    GitHub Action: New M1 runner available to all plans, including open source 🚀 actions/runner-images#9254 (comment)

This PR fixes the above issues by:

  1. Fixing the GPU detection logic when running on M1 Mac to fall back to CPU. Note that the Mac CI and Regression only runs on CPU, when running on the github runner. To run on MPS, a self hosted runner will need to be created.
  2. Update CI and regression tests to run on both CPU only and MPS on M1 Mac

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

@namannandan namannandan force-pushed the fix-mac-ci branch 7 times, most recently from 909bb6f to ec18c37 Compare May 1, 2024 23:48
@namannandan namannandan marked this pull request as ready for review May 6, 2024 22:52
@namannandan namannandan changed the title Update ci and regression cpu workflow for MAC Fix CI and Regression workflows for MAC Arm64 May 6, 2024
@namannandan namannandan added this to the v0.11.0 milestone May 7, 2024
@namannandan namannandan self-assigned this May 7, 2024
mreso
mreso approved these changes May 9, 2024
View reviewed changes
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mreso mreso added this pull request to the merge queue May 9, 2024
Merged via the queue into master with commit 087e813 May 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mreso mreso mreso approved these changes

@agunapal agunapal Awaiting requested review from agunapal

@lxning lxning Awaiting requested review from lxning

@udaij12 udaij12 Awaiting requested review from udaij12

Assignees

@namannandan namannandan

Labels
None yet
Projects
v0.11.0 lifecycle
Status: Done
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@namannandan @mreso