Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Llama 3 support to chat bot example #3131

Merged
merged 7 commits into from
May 3, 2024
Merged

Conversation

mreso
Copy link
Collaborator

@mreso mreso commented May 3, 2024

Description

This PR adds Llama3 support to the chat bot example (Llama 2 stays supported by changing model identifier)

Fixes #(issue)
#3099

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • docker run --rm -it --platform linux/amd64 -p 127.0.0.1:8080:8080 -p 127.0.0.1:8081:8081 -p 127.0.0.1:8082:8082 -p 127.0.0.1:8084:8084 -p 127.0.0.1:8085:8085 -v /Users/mreso/Projects/serve/model_store_1:/home/model-server/model-store -e MODEL_NAME=meta-llama/Meta-Llama-3-8B-Instruct pytorch/torchserve:chat_bot

image

image

Checklist:

  • Did you have fun?
  • Have you made corresponding changes to the documentation?

@mreso mreso requested a review from agunapal May 3, 2024 01:17
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Show resolved Hide resolved
examples/LLM/llama/chat_app/docker/Dockerfile Show resolved Hide resolved
@mreso mreso enabled auto-merge May 3, 2024 20:54
@mreso mreso added this pull request to the merge queue May 3, 2024
Merged via the queue into master with commit ffe1ed2 May 3, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants