Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Inf2 benchmark #3177

Merged
merged 12 commits into from
Jun 5, 2024
Merged

Fix Inf2 benchmark #3177

merged 12 commits into from
Jun 5, 2024

Conversation

namannandan
Copy link
Collaborator

Description

Inf2 benchmarks have been failing due to the following reasons:

  1. The latest version of torch-neuronx requires torch 2.1.2 and torch was pinned to 1.13
  2. Although setuptools is pinned, it was getting upgraded when loading the benchmark models due to installation of custom dependencies ex: torch-neuronx. Related issue: ImportError: cannot import name 'packaging' from 'pkg_resources' #3176

Fix:

  1. Pin torch to a know supported version for neuronx
  2. Update Inf2 model artifacts to not use custom dependencies since these are already setup by install_dependencies.py script before running the benchmark.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Copy link
Collaborator

@udaij12 udaij12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namannandan namannandan added this pull request to the merge queue Jun 5, 2024
Merged via the queue into master with commit dd1f8dc Jun 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants