Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for hpu_backend and Resnet50 compile example #3182

Merged
merged 8 commits into from
Jun 24, 2024

Conversation

wozna
Copy link
Contributor

@wozna wozna commented Jun 7, 2024

Description

The changes add support for hpu_backend and provide an example for resnet50 for compile.

Type of change

  • New feature (non-breaking change which adds functionality)

Feature/Issue validation/testing

In order to show how to run torchserve on HPU, I added an example of running Resnet50 with a description and a modified handler.

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@wozna
Copy link
Contributor Author

wozna commented Jun 10, 2024

@agunapal Can I ask you to review my proposal?

@agunapal
Copy link
Collaborator

@agunapal Can I ask you to review my proposal?

Hi @wozna Thanks for the PR. Please wait till #3166 is merged. You would have to edit your PR once this is merged.

examples/pt2/torch_compile_hpu/README.md Show resolved Hide resolved
examples/pt2/torch_compile_hpu/README.md Show resolved Hide resolved
examples/pt2/torch_compile_hpu/README.md Outdated Show resolved Hide resolved
python ./ts_scripts/install_dependencies.py --skip_torch_install

# Latest release
python install -c torchserve torch-model-archiver torch-workflow-archiver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to use nightlies here for the new config to work.

@wozna wozna requested a review from agunapal June 24, 2024 17:10
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal enabled auto-merge June 24, 2024 17:25
@agunapal agunapal added this pull request to the merge queue Jun 24, 2024
Merged via the queue into pytorch:master with commit 42e3fb1 Jun 24, 2024
11 of 12 checks passed
@agunapal agunapal added this to the v0.12.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants