Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workaround for compile example failure #3190

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

agunapal
Copy link
Collaborator

@agunapal agunapal commented Jun 12, 2024

Description

This is a workaround for nightly failure.
Issue happens with conda binaries only

=========================== short test summary info ============================
FAILED test_example_torch_compile.py::test_torch_compile_inference - AssertionError: assert ['tiger_cat',...'plastic_bag'] == ['tabby', 'ti...'plastic_bag']
  At index 0 diff: 'tiger_cat' != 'tabby'
  Full diff:
  - ['tabby', 'tiger_cat', 'Egyptian_cat', 'lynx', 'plastic_bag']
  ?  ---------
  + ['tiger_cat', 'tabby', 'Egyptian_cat', 'lynx', 'plastic_bag']

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal added this to the v0.12.0 milestone Jun 12, 2024
@agunapal agunapal requested a review from udaij12 June 12, 2024 21:17
Copy link
Collaborator

@udaij12 udaij12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@udaij12 udaij12 added this pull request to the merge queue Jun 12, 2024
@udaij12 udaij12 removed this pull request from the merge queue due to a manual request Jun 12, 2024
@udaij12 udaij12 enabled auto-merge June 12, 2024 21:24
@udaij12 udaij12 added this pull request to the merge queue Jun 12, 2024
Merged via the queue into master with commit 9099073 Jun 12, 2024
12 checks passed
@udaij12 udaij12 deleted the issues/test_compile_conda_failure branch June 12, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants