Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark numpy fix #3197

Merged
merged 11 commits into from
Jun 20, 2024
Merged

Benchmark numpy fix #3197

merged 11 commits into from
Jun 20, 2024

Conversation

udaij12
Copy link
Collaborator

@udaij12 udaij12 commented Jun 20, 2024

Description

Numpy release of 2.0 has caused issues in the benchmark script.
Solution is to add the same numpy pin in the benchmark requirements file

Testing

https://github.com/pytorch/serve/actions/runs/9592493747/job/26451152735

@udaij12 udaij12 marked this pull request as ready for review June 20, 2024 15:55
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal added this pull request to the merge queue Jun 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 20, 2024
@udaij12 udaij12 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into master with commit 079ff7b Jun 20, 2024
12 checks passed
@udaij12 udaij12 deleted the nightly_fix branch June 20, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants