Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image_classifier/densenet-161 to include torch.compile #3200

Merged
merged 2 commits into from
Jun 22, 2024

Conversation

lzcemma
Copy link
Contributor

@lzcemma lzcemma commented Jun 21, 2024

Description

Update image_classifier/densenet-161 to include torch.compile

Add model config file
Update README

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

  • TorchServe starts logs
2024-06-21T15:16:28,320 [INFO ] W-9035-densenet161_1.0-stdout MODEL_LOG - [PID]3640610
2024-06-21T15:16:28,320 [INFO ] W-9002-densenet161_1.0-stdout MODEL_LOG - Python runtime: 3.12.2
2024-06-21T15:16:28,320 [INFO ] W-9035-densenet161_1.0-stdout MODEL_LOG - Torch worker started.
2024-06-21T15:16:28,320 [INFO ] W-9011-densenet161_1.0-stdout MODEL_LOG - Torch worker started.
  • Output prediction
    Logs for Test B
{
  "tabby": 0.4664836823940277,
  "tiger_cat": 0.4645617604255676,
  "Egyptian_cat": 0.06619937717914581,
  "lynx": 0.0012969186063855886,
  "plastic_bag": 0.00022856894065625966
}

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lzcemma Thanks for the PR! Can you please move the torch.compile section to the top. We want users to try torch.compile by default

@agunapal agunapal added this to the v0.12.0 milestone Jun 21, 2024
@lzcemma
Copy link
Contributor Author

lzcemma commented Jun 21, 2024

Hi @lzcemma Thanks for the PR! Can you please move the torch.compile section to the top. We want users to try torch.compile by default

Hi @agunapal Thanks for review. I updated the README and torch.compile section is on top now.

@lzcemma lzcemma requested a review from agunapal June 21, 2024 23:27
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agunapal agunapal enabled auto-merge June 21, 2024 23:34
@agunapal agunapal added this pull request to the merge queue Jun 21, 2024
Merged via the queue into pytorch:master with commit 688f09e Jun 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants