Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BERT with torch.compile #3201

Merged
merged 10 commits into from
Jun 27, 2024
Merged

BERT with torch.compile #3201

merged 10 commits into from
Jun 27, 2024

Conversation

agunapal
Copy link
Collaborator

Description

This updates the BERT example to also use torch.compile

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@agunapal agunapal added this to the v0.12.0 milestone Jun 22, 2024
@agunapal agunapal requested a review from mreso June 22, 2024 00:21
Copy link
Collaborator

@mreso mreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments. LGTM otherwise

@agunapal agunapal enabled auto-merge June 27, 2024 19:44
@agunapal agunapal added this pull request to the merge queue Jun 27, 2024
Merged via the queue into master with commit affdcdd Jun 27, 2024
12 checks passed
@agunapal agunapal deleted the examples/bert_compile branch June 27, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants