Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken llm deployment link #3214

Merged
merged 2 commits into from
Jul 2, 2024
Merged

fix broken llm deployment link #3214

merged 2 commits into from
Jul 2, 2024

Conversation

msaroufim
Copy link
Member

wasn't rendering correctly

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A
    Logs for Test A

  • Test B
    Logs for Test B

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

wasn't rendering correctly
@msaroufim msaroufim requested review from mreso and agunapal and removed request for mreso June 28, 2024 18:17
@mreso mreso enabled auto-merge June 28, 2024 19:35
@mreso
Copy link
Collaborator

mreso commented Jun 28, 2024

Good catch @msaroufim Thanks!

@msaroufim
Copy link
Member Author

It's a very cool addition btw, @agunapal just shared it with me

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for checking!

@mreso mreso added this pull request to the merge queue Jul 2, 2024
Merged via the queue into master with commit b4bbc29 Jul 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants