Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean a jobGroup immediately when it finished #3222

Merged
merged 9 commits into from
Jul 3, 2024
Merged

clean a jobGroup immediately when it finished #3222

merged 9 commits into from
Jul 3, 2024

Conversation

lxning
Copy link
Collaborator

@lxning lxning commented Jul 2, 2024

Description

Please read our CONTRIBUTING.md prior to creating your first pull request.

Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #(issue)

This PR is to address two issues, which caused the delay of releasing jobGroups and threadpool resource, and fix the logical break introduced in #3198

  • issue1: not cleanup a jobGroup immediately when its sequence is end.
  • issue2: not stop a thread immediately when a jobGroup is in state of "polling a job".

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test
pytest -s test_example_stateful_sequence_continuous_batching_http.py
========================== 3 passed in 89.92s (0:01:29) ==========================

Checklist:

  • Did you have fun?
  • Have you added tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

@lxning lxning changed the title [WIP] refactor clean a jobGroup immediately when the sequence is end Jul 3, 2024
@lxning lxning requested review from namannandan and mreso July 3, 2024 03:22
@lxning lxning changed the title clean a jobGroup immediately when the sequence is end clean a jobGroup immediately when it finished Jul 3, 2024
@lxning lxning enabled auto-merge July 3, 2024 04:50
@lxning lxning requested review from agunapal and removed request for agunapal July 3, 2024 16:38
@lxning lxning added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit 55bcf9d Jul 3, 2024
12 checks passed
@lxning lxning self-assigned this Jul 9, 2024
@lxning lxning added the bug Something isn't working label Jul 9, 2024
@lxning lxning added this to the v0.12.0 milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants