T5 Translation with torch.compile & TensorRT backend #3223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agunapal
changed the title
mreso
approved these changes
Jul 9, 2024
| - Verified to be working with `torch-tensorrt==2.3.0` | ||
| Installation instructions can be found in [pytorch/TensorRT](https://github.com/pytorch/TensorRT) | ||
|
|
||
| Change directory to examples directory `cd examples/torch_tensorrt/T5/torchcompile` |
There was a problem hiding this comment.
Should we revert the order and do examples/torch_compile/tensor_rt instead? Then we could move all examples/pt2 into there too so people find everything about compile in a single place? I assume there will be no other integration point for TRT in the future other than compile.
There was a problem hiding this comment.
For tensorrt, onnx, we actually want the starting point to be tensorrt, onnx, since customers are looking specifically for these. There are github issues where customers are still looking for an onnx example. Will add an example on onnx next
| # read configs for the mode, model_name, etc. from the handler config | ||
| model_path = self.model_yaml_config.get("handler", {}).get("model_path", None) | ||
| if not model_path: | ||
| logger.warning("Missing model path") |
Co-authored-by: Matthias Reso <13337103+mreso@users.noreply.github.com>
review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR shows how to serve T5 model for translation with TensorRT using torch.compile
Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Test A
Logs for Test A
Test B
Logs for Test B
Checklist: