Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating examples for security tags #3224

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Updating examples for security tags #3224

merged 3 commits into from
Jul 3, 2024

Conversation

udaij12
Copy link
Collaborator

@udaij12 udaij12 commented Jul 3, 2024

Description

adding --disable-token-auth and --enable-model-api to examples

@udaij12 udaij12 marked this pull request as ready for review July 3, 2024 16:13
@agunapal
Copy link
Collaborator

agunapal commented Jul 3, 2024

Hi @udaij12 I think we should be adding --enable-model-api only when we are registering models after TorchServe has started. Otherwise , it would confuse the users.

agunapal
agunapal approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@udaij12 udaij12 added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit 589b351 Jul 3, 2024
12 checks passed
This was referenced Jul 5, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agunapal agunapal agunapal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@udaij12 @agunapal