Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds torch.compile documentation to alexnet example readme #3227

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

crmdias
Copy link
Contributor

@crmdias crmdias commented Jul 3, 2024

Description

Adds instructions on how to serve alexnet model with torch.compile

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Feature/Issue validation/testing

Manual execution of the steps in the documentation renders the documented results

Checklist:

  • Did you have fun?
    Have you added tests that prove your fix is effective or that this feature works? Doc Only
    Has code been commented, particularly in hard-to-understand areas? Doc Only
  • Have you made corresponding changes to the documentation?

Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good! A couple of minor edits are needed.

examples/image_classifier/alexnet/README.md Outdated Show resolved Hide resolved
examples/image_classifier/alexnet/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agunapal agunapal enabled auto-merge July 3, 2024 19:21
@agunapal agunapal added this pull request to the merge queue Jul 3, 2024
Merged via the queue into master with commit 4573482 Jul 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants