-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding token auth and model api to workflow and https #3234
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have tests for the behavior when you enable token-auth?
The two tests added are with token auth enabled |
Can you please add tests for the reverse case. i.e without a token , they should fail |
Added two tests without token which fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment. LGTM otherwise
Description
Adding token auth tests to workflow and https
Added model control tests to https
Workflow does not need model control tests as the model registered with the workflow.