Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding token auth and model api to workflow and https #3234

Merged
merged 12 commits into from
Jul 12, 2024
Merged

Conversation

udaij12
Copy link
Collaborator

@udaij12 udaij12 commented Jul 9, 2024

Description

Adding token auth tests to workflow and https
Added model control tests to https

Workflow does not need model control tests as the model registered with the workflow.

@udaij12 udaij12 marked this pull request as ready for review July 10, 2024 23:15
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have tests for the behavior when you enable token-auth?

@udaij12
Copy link
Collaborator Author

udaij12 commented Jul 11, 2024

The two tests added are with token auth enabled

@agunapal
Copy link
Collaborator

The two tests added are with token auth enabled

Can you please add tests for the reverse case. i.e without a token , they should fail

@udaij12
Copy link
Collaborator Author

udaij12 commented Jul 11, 2024

Added two tests without token which fail

@udaij12 udaij12 changed the title Adding token auth and model api to workflow Adding token auth and model api to workflow and https Jul 11, 2024
Copy link
Collaborator

@agunapal agunapal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment. LGTM otherwise

@udaij12 udaij12 added this pull request to the merge queue Jul 12, 2024
Merged via the queue into master with commit f717497 Jul 12, 2024
12 checks passed
@udaij12 udaij12 deleted the workflow_update branch July 12, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants