-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable startup time #3262
Conversation
… model_load_timeout is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Please see my comment regarding testing. Otherwise this look good to go after adjusting the test.
frontend/server/src/main/java/org/pytorch/serve/wlm/WorkerThread.java
Outdated
Show resolved
Hide resolved
…20/torchserve into configurable-startup-time
I see some checks are failing but I'm not sure what the issue really is, to fix it |
Yeah, these regression tests can be a pain. Taking a look |
One of the tests was failing due to startup_timeout not being cast to int in |
Seems like tests have passed(required ones). Docker ones are failing due to: |
Hi @Isalia20 yes, that should be the docker build script which only supports pytorch/serve as remote. We can proceed with merging this PR. Thanks again for your contribution! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
Description
Adds feature from #3261 and from #2452
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
================================================================================ test session starts =================================================================================
platform linux -- Python 3.10.14, pytest-7.3.1, pluggy-1.0.0
rootdir: /home/isalia/Desktop/torchserve
plugins: mock-3.14.0, timeout-2.3.1, cov-4.1.0, typeguard-4.3.0
collected 1 item
test/pytest/test_startup_timeout.py . [100%]
================================================================================= 1 passed in 15.02s =================================================================================
Checklist: