Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix benchmarks/README typo and JMeter versioning issue #412

Closed
wants to merge 1 commit into from

Conversation

maaquib
Copy link
Collaborator

@maaquib maaquib commented May 28, 2020

Description

  • Fixes script failure on newer versions of JMeter (5.3)
  • Fix typo in README in the name of dependency script

Related: Issue #98 and PR #126

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing

Ran

  • ./benchmarks/mac_install_dependencies.sh on Mac
  • ./benchmarks/install_dependencies.sh
  • ./benchmarks/install_dependencies.sh True
  • python benchmark.py throughput --ts http://127.0.0.1:8080

Checklist:

  • Have you added tests that prove your fix is effective or that this feature works?
  • New and existing unit tests pass locally with these changes?

@maaquib maaquib self-assigned this May 28, 2020
@maaquib maaquib added this to the v0.1.1 milestone May 28, 2020
@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-cpu
  • Commit ID: 80edb4b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@sagemaker-neo-ci-bot
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: torch-serve-build-gpu
  • Commit ID: 80edb4b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@maaquib
Copy link
Collaborator Author

maaquib commented May 29, 2020

Changes incorporatd in #402

@maaquib maaquib closed this May 29, 2020
@maaquib maaquib removed this from the v0.1.1 milestone May 29, 2020
@maaquib maaquib deleted the issue_98_typo branch May 29, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linuxbrew (benchmark dependency) outdated
2 participants